Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: gin log to file #574

Merged
merged 2 commits into from
Aug 25, 2021
Merged

feat: gin log to file #574

merged 2 commits into from
Aug 25, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Gin log to file.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 25, 2021
@gaius-qi gaius-qi self-assigned this Aug 25, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 25, 2021 08:07
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #574 (7752cc9) into main (64e83a9) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   39.04%   39.10%   +0.06%     
==========================================
  Files          86       86              
  Lines        6644     6644              
==========================================
+ Hits         2594     2598       +4     
+ Misses       3678     3673       -5     
- Partials      372      373       +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.10% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.04% <0.00%> (-0.64%) ⬇️
client/daemon/peer/peertask_stream.go 56.44% <0.00%> (+2.43%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 70e5412 into main Aug 25, 2021
@gaius-qi gaius-qi deleted the feature/gin-zap branch August 25, 2021 08:58
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: gin log to file

Signed-off-by: Gaius <gaius.qi@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants