Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimize backsource logic and report peer result #589

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 30, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner August 30, 2021 04:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #589 (13c4b4e) into main (1d038fa) will increase coverage by 0.15%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   39.00%   39.15%   +0.15%     
==========================================
  Files          86       86              
  Lines        6674     6704      +30     
==========================================
+ Hits         2603     2625      +22     
- Misses       3698     3706       +8     
  Partials      373      373              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.15% <36.36%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.07% <22.22%> (-0.61%) ⬇️
client/daemon/peer/peertask_file_callback.go 62.96% <50.00%> (ø)
client/daemon/peer/peertask_stream_callback.go 64.55% <50.00%> (+2.53%) ⬆️
client/daemon/peer/peertask_file.go 53.90% <60.00%> (+0.14%) ⬆️
client/daemon/peer/peertask_stream.go 56.94% <85.71%> (+3.68%) ⬆️

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma force-pushed the feature/stability branch from 8e9b52c to 57e9f83 Compare August 30, 2021 04:14
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit c955317 into main Aug 30, 2021
@244372610 244372610 deleted the feature/stability branch August 30, 2021 11:05
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* chore: optimize backsource logic and report peer result

Signed-off-by: Jim Ma <majinjing3@gmail.com>

* chore: optimize peer task success logic

Signed-off-by: Jim Ma <majinjing3@gmail.com>

* chore: add back source trace

Signed-off-by: Jim Ma <majinjing3@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants