Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add sni proxy support #600

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Add sni proxy support #600

merged 1 commit into from
Sep 3, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Sep 3, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner September 3, 2021 03:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #600 (3f60c30) into main (86c90ea) will decrease coverage by 0.63%.
The diff coverage is 1.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   39.11%   38.48%   -0.64%     
==========================================
  Files          86       88       +2     
  Lines        6701     6923     +222     
==========================================
+ Hits         2621     2664      +43     
- Misses       3708     3884     +176     
- Partials      372      375       +3     
Flag Coverage Δ
e2etests ?
unittests 38.48% <1.25%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 35.48% <ø> (ø)
client/daemon/daemon.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 34.49% <0.00%> (+1.02%) ⬆️
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)
client/daemon/proxy/proxy_sni.go 0.00% <0.00%> (ø)
client/daemon/proxy/proxy.go 8.01% <25.00%> (+0.03%) ⬆️
manager/permission/rbac/rbac.go 16.66% <0.00%> (-6.42%) ⬇️
cdnsystem/errors/errors.go 76.66% <0.00%> (-2.65%) ⬇️
cdnsystem/supervisor/cdn/manager.go 61.40% <0.00%> (-0.55%) ⬇️
cdnsystem/rpcserver/rpcserver.go 0.64% <0.00%> (-0.02%) ⬇️
... and 7 more

@jim3ma jim3ma force-pushed the feature/sni-proxy branch 2 times, most recently from f04f2d0 to c8cdc70 Compare September 3, 2021 05:40
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit f208dd7 into main Sep 3, 2021
@jim3ma jim3ma deleted the feature/sni-proxy branch September 3, 2021 10:14
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants