Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add idgen peer id #800

Merged
merged 4 commits into from
Nov 15, 2021
Merged

feat: add idgen peer id #800

merged 4 commits into from
Nov 15, 2021

Conversation

gaius-qi
Copy link
Member

Description

  • Generate peer id and cdn peer id func.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi
feat: add scheduler validation
d22ba61 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
feat: idgen add peer id
ad73ab0 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
feat: remove validation
e4f12c5 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 15, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 15, 2021 10:12
@gaius-qi gaius-qi self-assigned this Nov 15, 2021
@gaius-qi
feat: remove grpc validate middleware
f26410c 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi changed the title Feature/idgen peer feat: add idgen peer id Nov 15, 2021
yxxhero
yxxhero approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 6f32500 into main Nov 15, 2021
@jim3ma jim3ma deleted the feature/idgen-peer-id branch November 15, 2021 11:40
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: add idgen peer id (#800)
558782a 
Signed-off-by: Gaius <gaius.qi@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@yxxhero yxxhero yxxhero approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
client
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gaius-qi @jim3ma @yxxhero