Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: unify binary directory #828

Merged
merged 1 commit into from
Nov 25, 2021
Merged

chore: unify binary directory #828

merged 1 commit into from
Nov 25, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Nov 25, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner November 25, 2021 04:27
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #828 (7777d82) into main (03cb54d) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   41.14%   41.07%   -0.08%     
==========================================
  Files         102      102              
  Lines        8066     8066              
==========================================
- Hits         3319     3313       -6     
- Misses       4337     4343       +6     
  Partials      410      410              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.07% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 46.06% <0.00%> (-1.22%) ⬇️

@yxxhero yxxhero merged commit 1247514 into main Nov 25, 2021
@yxxhero yxxhero deleted the unify-binary-directory branch November 25, 2021 04:54
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants