New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

action: add zran-no-prefetch benchmark and make smoke.yml tidy #1239

Merged

imeoer merged 3 commits into dragonflyoss:master from Desiki-high:smoke-clear

Apr 22, 2023

Member

Desiki-high commented Apr 21, 2023 •

edited

Loading

Benchmark in smoke test has too many same steps, we can move them to shell and make smoke.yml tidy by prepare_env.sh and benchmark_summary.sh.
Add zran-no-prefetch benchmark.
Change the benchmark-result order, set the oci in the first.
Since action: fix checkout on pull_request_target #1238, we move the benchmark-result from PR comment to action summary, we should enable benchmark-result in push and schedule.
Use the stable wordpress tag 6.11.
Delete the artifacts after benchmark-result download all artifacts. Certainly, the nydus-integration-test had downloaded the artifacts.

Desiki-high requested review from a team as code owners

April 21, 2023 05:50

Desiki-high requested review from liubin, imeoer and changweige and removed request for a team

April 21, 2023 05:50

anolis-bot added the anolis_testing label

This comment was marked as outdated.

# to view

codecov bot commented Apr 21, 2023 •

edited

Loading

Codecov Report

Merging #1239 (86992c5) into master (0d2958e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   41.36%   41.34%   -0.02%     
==========================================
  Files         126      126              
  Lines       37336    37336              
  Branches    37336    37336              
==========================================
- Hits        15443    15438       -5     
- Misses      21158    21165       +7     
+ Partials      735      733       -2

see 3 files with indirect coverage changes

Desiki-high changed the title ~~clear the smoke.yml~~ [WIP]clear the smoke.yml

Desiki-high force-pushed the smoke-clear branch 3 times, most recently from 504655b to 9d19eea Compare

April 21, 2023 06:15

anolis-bot added anolis_test_pass and removed anolis_testing labels

This comment was marked as outdated.

# to view

Desiki-high force-pushed the smoke-clear branch 2 times, most recently from 22dbd08 to 82d3610 Compare

April 21, 2023 06:56

Desiki-high changed the title ~~[WIP]clear the smoke.yml~~ [WIP]action: add zran-no-prefetch benchmark and make smoke.yml tidy

Desiki-high force-pushed the smoke-clear branch from 1328e28 to b206fc9 Compare

April 21, 2023 07:32

Desiki-high changed the title ~~[WIP]action: add zran-no-prefetch benchmark and make smoke.yml tidy~~ action: add zran-no-prefetch benchmark and make smoke.yml tidy

anolis-bot added anolis_testing and removed anolis_test_pass labels

This comment was marked as outdated.

# to view

Desiki-high requested a review from jiangliu

April 21, 2023 08:15

Desiki-high force-pushed the smoke-clear branch from 52b825c to aab24cb Compare

April 21, 2023 08:23

This comment was marked as outdated.

# to view

This comment was marked as outdated.

# to view

This comment was marked as outdated.

# to view

anolis-bot removed the anolis_testing label

This comment was marked as outdated.

# to view

anolis-bot added anolis_test_pass and removed anolis_testing labels

This comment was marked as outdated.

# to view

This comment was marked as outdated.

# to view

Desiki-high force-pushed the smoke-clear branch from 08eab6e to 5181f3c Compare

April 22, 2023 05:52

anolis-bot added anolis_testing and removed anolis_test_pass labels

This comment was marked as outdated.

# to view

This comment was marked as outdated.

# to view

anolis-bot added anolis_test_fail and removed anolis_testing labels

This comment was marked as outdated.

# to view


          misc: delete unused benchmark code

d5f37c0

Signed-off-by: Desiki-high <ding_yadong@foxmail.com>

This comment was marked as outdated.

# to view

Desiki-high force-pushed the smoke-clear branch from 5181f3c to a9dfa53 Compare

April 22, 2023 06:11

anolis-bot added anolis_testing and removed anolis_test_fail labels

This comment was marked as outdated.

# to view

Desiki-high added 2 commits

April 22, 2023 14:25


          misc: create shell for benchmark

f7c90dc

1. prepare_env.sh for prepare container environment.
2. benchmark_summary.sh for benchmark-result to summary result.

Signed-off-by: Desiki-high <ding_yadong@foxmail.com>


          action: add zran-no-prefetch in benchmark

86992c5

1. add the zran without prefetch benchmark.
2. move the same steps to prepare_env.sh.
3. move benchmark summary script to benchmark_summary.sh.
3. change the benchmark-result order and enable in push and schedule.
4. set stable the wordpress tag 6.1.1.
5. delete the artifacts after benchmark-result download all artifacts.

Signed-off-by: Desiki-high <ding_yadong@foxmail.com>

Desiki-high force-pushed the smoke-clear branch from a9dfa53 to 86992c5 Compare

April 22, 2023 06:25

Collaborator

anolis-bot commented Apr 22, 2023

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69408

anolis-bot added anolis_test_pass and removed anolis_testing labels

This comment was marked as outdated.

# to view

Collaborator

anolis-bot commented Apr 22, 2023

@Desiki-high , The CI test is completed, please check result:

Test Case		Test Result
build rust golang image		✅ SUCCESS
compile nydusd		✅ SUCCESS
compile ctr remote		✅ SUCCESS
compile nydus snapshotter		✅ SUCCESS
run container with rafs		✅ SUCCESS
run container with zran		✅ SUCCESS
run container with rafs and compile linux		✅ SUCCESS

Congratulations, your test job passed!

imeoer approved these changes

View reviewed changes

imeoer merged commit 1088f47 into dragonflyoss:master

Desiki-high deleted the smoke-clear branch

April 22, 2023 08:24

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

imeoer imeoer approved these changes

liubin Awaiting requested review from liubin liubin is a code owner automatically assigned from dragonflyoss/nydus-maintainers

changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-maintainers

jiangliu Awaiting requested review from jiangliu

Labels

anolis_test_pass