Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: upload-coverage failed in master #1582

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

image

Details

When action don't run on pull request, Codecov GitHub Action V4 need token.
Refence:

  1. https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes
  2. https://docs.codecov.com/docs/codecov-uploader#supporting-token-less-uploads-for-forks-of-open-source-repos-using-codecov

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner June 4, 2024 06:35
@Desiki-high Desiki-high requested review from liubogithub, jiangliu and changweige and removed request for a team June 4, 2024 06:35
@Desiki-high Desiki-high force-pushed the fix/action-codecov-v4 branch from 7d8b753 to 104af3e Compare June 4, 2024 06:55
@Desiki-high Desiki-high force-pushed the fix/action-codecov-v4 branch from 104af3e to 45a8d1d Compare June 4, 2024 06:56
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (e926d2f) to head (45a8d1d).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   61.23%   61.51%   +0.27%     
==========================================
  Files         144      144              
  Lines       47100    46616     -484     
  Branches    44602    44602              
==========================================
- Hits        28843    28675     -168     
+ Misses      16778    16457     -321     
- Partials     1479     1484       +5     

see 19 files with indirect coverage changes

@imeoer
Copy link
Collaborator

imeoer commented Jun 4, 2024

Thanks for the fixup!

@imeoer imeoer merged commit 305a418 into dragonflyoss:master Jun 4, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants