feat: skip proxy health check if connection is not active #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceAko
requested review from
changweige,
adamqqqplay and
hsiangkao
and removed request for
a team
BruceAko
force-pushed
the
master
branch
4 times, most recently
from
74bdd96 to
ac5aedf
Compare
imeoer
reviewed
Jul 4, 2024
|
Also need to handle the |
|
Please also update the doc for these sections:
|
BruceAko
force-pushed
the
master
branch
7 times, most recently
from
ed40f0a to
bb18970
Compare
|
The above has been revised, PTAL, thanks. @imeoer |
imeoer
approved these changes
Jul 9, 2024
api/src/config.rs
Outdated
| @@ -938,6 +942,9 @@ pub struct MirrorConfig { | |||
| /// Maximum number of failures before marking a mirror as unusable. | |||
| #[serde(default = "default_failure_limit")] | |||
| pub failure_limit: u8, | |||
| /// Elapsed time to pause mirror health check when the request is inactive, in seconds. | |||
| #[serde(default = "default_check_pause_elapsed")] | |||
| pub check_pause_elapsed: u64, | |||
There was a problem hiding this comment.
We have health_check_interval, so maybe name it health_check_pause_elapsed ?
There was a problem hiding this comment.
Fixed, PTAL :) @imeoer
1. Add last_active field for Connection. When Connection.call() is called, last_active is updated to current timestamp. 2. Add check_pause_elapsed field for ProxyConfig and MirrorConfig. Connection is considered to be inactive if the current time to the last_active time exceeds check_pause_elapsed. 3. In proxy and mirror's health checking thread's loop, if the connection is not active (exceeds check_pause_elapsed), this round of health check is skipped. 4. Update the document. Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
imeoer
approved these changes
Jul 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Fixes #1588
Details
last_activefield forConnection. WhenConnection.call()is called,last_activeis updated to current timestamp.check_pause_elapsedfield forProxyConfigandMirrorConfig. Connection is considered to be inactive if the current time to thelast_activetime exceedscheck_pause_elapsed.check_pause_elapsed), this round of health check is skipped.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.