Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update project name when performing soft delete #31

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: update project name when performing soft delete #31

wants to merge 7 commits into from
+140 −7

Conversation

sachdevavaibhav
Copy link

@sachdevavaibhav sachdevavaibhav commented Feb 28, 2025 •
edited by ashutoshd11
Loading

  • Fix: update project name when performing soft delete using timestamp so that the field remains unique.

Fixes #20

@sachdevavaibhav sachdevavaibhav force-pushed the sachdevavaibhav/fix-soft-delete branch from 655b0f2 to de6dde9 Compare February 28, 2025 12:38
ashutoshd11
ashutoshd11 reviewed Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@ashutoshd11 ashutoshd11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding current implementation I am not seeing any changes in app/routes/api/v1/updateProjectStatus.ts but there are changes in it's test file, this is working because schema is not strictly implemented by zod at API, will do this in upcoming PRs.

@sachdevavaibhav
Copy link
Author

@ashutoshd11
I understood what I did wrong. I will be make changes in the controller and also need to make changes in DAO such that it handles other status updates and soft delete as well. Will make the changes and push them.

@sachdevavaibhav
Copy link
Author

@ashutoshd11 I have updated the controller and dao. Can you please check?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yashawasthi10 yashawasthi10 Awaiting requested review from yashawasthi10 yashawasthi10 is a code owner

@ashutoshd11 ashutoshd11 Awaiting requested review from ashutoshd11 ashutoshd11 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After deleting a project cannot create with the same name.
2 participants
@sachdevavaibhav @ashutoshd11