Skip to content

Commit

Permalink
feat: removed all logger
Browse files Browse the repository at this point in the history
  • Loading branch information
shubhamguptadream11 committed Nov 13, 2024
1 parent 1c356f3 commit 3e5949e
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package com.performancetracker

import android.content.Context
import android.graphics.Canvas
import android.util.Log
import com.facebook.react.bridge.ReactContext
import com.facebook.react.uimanager.UIManagerHelper
import com.facebook.react.views.view.ReactViewGroup
Expand All @@ -22,7 +21,6 @@ class PerformanceTrackerView(context: Context) : ReactViewGroup(context) {
val time = System.currentTimeMillis().toDouble()
PerformanceTrackerStore.addEvent(tagName, time)
val renderTime = time - eventTimeStamp
Log.d("::: Shubham ", "onDraw $tagName $time")
UIManagerHelper.getEventDispatcherForReactTag(reactContext, reactTag)?.dispatchEvent(DrawEndEvent(reactTag, tagName, time, renderTime))

PerformanceTrackerWriter.writeLogsInFile(tagName, time.toString())
Expand Down
2 changes: 0 additions & 2 deletions android/src/newarch/PerformanceTrackerModule.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.performancetracker

import android.util.Log
import com.facebook.react.bridge.Promise
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactMethod
Expand All @@ -17,7 +16,6 @@ class PerformanceTrackerModule internal constructor(context: ReactApplicationCon

@ReactMethod
override fun send(tag: String, time: Double) {
Log.d("::: Shubham send called", "$tag $time " + Thread.currentThread());
PerformanceTrackerStore.addEvent(tag, time)

PerformanceTrackerWriter.writeLogsInFile(tag, time.toString())
Expand Down
4 changes: 0 additions & 4 deletions android/src/newarch/PerformanceTrackerViewManager.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.performancetracker

import android.graphics.Color
import android.util.Log
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.SimpleViewManager
import com.facebook.react.uimanager.ThemedReactContext
Expand All @@ -21,13 +20,11 @@ class PerformanceTrackerViewManager :
}

public override fun createViewInstance(context: ThemedReactContext): PerformanceTrackerView {
Log.d("::: Shubham ", " createViewInstance")
return PerformanceTrackerView(context)
}

@ReactProp(name = "isEnabled")
override fun setIsEnabled(view: PerformanceTrackerView?, value: Boolean) {
Log.d("::: Shubham", " setIsEnabled called $value")
if (view != null) {
view.enabledFlag = value
}
Expand All @@ -42,7 +39,6 @@ class PerformanceTrackerViewManager :

@ReactProp(name = "eventTimeStamp")
override fun setEventTimeStamp(view: PerformanceTrackerView?, value: Double) {
Log.d("::: Shubham", " setEventTimeStamp called")
if (view != null) {
view.eventTimeStamp = value
}
Expand Down
2 changes: 0 additions & 2 deletions android/src/oldarch/PerformanceTrackerModule.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.performancetracker

import android.util.Log
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactMethod
import com.facebook.react.bridge.Promise
Expand All @@ -19,7 +18,6 @@ class PerformanceTrackerModule internal constructor(context: ReactApplicationCon
// See https://reactnative.dev/docs/native-modules-android
@ReactMethod
fun send(tag: String, time: Double) {
Log.d("::: Shubham send called", "$tag $time " + Thread.currentThread());
PerformanceTrackerStore.addEvent(tag, time)

PerformanceTrackerWriter.writeLogsInFile(tag, time.toString())
Expand Down
3 changes: 0 additions & 3 deletions android/src/oldarch/PerformanceTrackerViewManager.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.performancetracker

import android.util.Log
import com.facebook.react.module.annotations.ReactModule
import com.facebook.react.uimanager.SimpleViewManager
import com.facebook.react.uimanager.ThemedReactContext
Expand All @@ -19,7 +18,6 @@ class PerformanceTrackerViewManager : ViewGroupManager<PerformanceTrackerView>()

@ReactProp(name = "isEnabled")
fun setIsEnabled(view: PerformanceTrackerView?, value: Boolean) {
Log.d("::: Shubham", " setIsEnabled called $value")
if (view != null) {
view.enabledFlag = value
}
Expand All @@ -34,7 +32,6 @@ class PerformanceTrackerViewManager : ViewGroupManager<PerformanceTrackerView>()

@ReactProp(name = "eventTimeStamp")
fun setEventTimeStamp(view: PerformanceTrackerView?, value: Double) {
Log.d("::: Shubham", " setEventTimeStamp called")
if (view != null) {
view.eventTimeStamp = value
}
Expand Down
22 changes: 2 additions & 20 deletions example/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState } from 'react';
import { useState } from 'react';
import {
StyleSheet,
Text,
Expand All @@ -14,15 +14,8 @@ export default function App() {
const [showPTView, setShowPTView] = useState(false);
const [res, _] = useState(0);

useEffect(() => {
console.log("::: Shubham useEffect mount called ", Date.now().toString());

}, [])

const getLogsFromNative = async () => {
const logs = await PerformanceTracker.getLogs();

console.log("::: Shubham logs", logs)
}
return (
<View>
Expand All @@ -40,14 +33,10 @@ export default function App() {
{showPTView &&
<View style={styles.container}>
<PerformanceTracker
onLayout={(e) => {
console.log("::: Shubham onLayout called ", e.timeStamp)
}}
style={{ borderWidth: 1, flex: 1 }}
tagName={'Parent Tracker'}
eventTimeStamp={Date.now()}
onDrawEnd={(data) => {
console.log(`::: Shubham Parent DrawTime: ${data.nativeEvent.drawTime} RenderTime: ${data.nativeEvent.renderTime} TagName: ${data.nativeEvent.tagName}`)
onDrawEnd={() => {
}}
>
<View
Expand All @@ -61,13 +50,6 @@ export default function App() {
}}
>
<Text>First View: {res}</Text>
{/* <PerformanceTracker tagName='Child Tracker' eventTimeStamp={Date.now()} isEnabled={false} onDrawEnd={(data) => {
console.log(`::: Shubham Children DrawTime: ${data.nativeEvent.drawTime} RenderTime: ${data.nativeEvent.renderTime} TagName: ${data.nativeEvent.tagName}`)
}}>
<View>
<Text>Children View</Text>
</View>
</PerformanceTracker> */}
</View>
</PerformanceTracker>
</View>
Expand Down

0 comments on commit 3e5949e

Please # to comment.