Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DPCP-8]: Google OAuth #5

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[DPCP-8]: Google OAuth #5

merged 1 commit into from
Jul 13, 2024

Conversation

angeloreale
Copy link
Collaborator

@angeloreale angeloreale commented Jul 13, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

ar(feat) DPCP-8: Google OAuth

This PR adds Google OAuth to Nyx+Hypnos.

Screenshots/Videocasts/Preview Links

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added screenshots? (if relevant)
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hypnos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 8:20am

Copy link

Add Google OAuth

@angeloreale
Copy link
Collaborator Author

angeloreale commented Jul 13, 2024

Needs deployment to test ACs via Nyx.

@angeloreale angeloreale merged commit a4f05e0 into dev Jul 13, 2024
5 checks passed
@angeloreale angeloreale deleted the ar/feat/dpcp-8--google-oauth branch July 13, 2024 08:33
@angeloreale
Copy link
Collaborator Author

angeloreale commented Jul 13, 2024

This worked via Preview link on Nyx after deploying Hypnos. Could log in via Google. It is erroring in prod. Not willing to debug now.

@angeloreale
Copy link
Collaborator Author

tl;dr this exact config/code works for all providers on another project. Won't go into a pointless rabbit hole.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant