Update jsonschema-rs & error messages formatting #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobileka
reviewed
Jun 2, 2021
spec/rusty_json_schema_spec.rb
Outdated
| "'\"rusty\"' is not of type 'number'", | ||
| "'1' is not of type 'string'", | ||
| "'baz' is a required property" | ||
| %("rusty" is not of type "number" at /bar), |
There was a problem hiding this comment.
Just a matter of taste but I would format this as follows:
path "foo": "rusty" is not of type "number"
I think that it's easier for humans to read this as most of them, in my opinion, think in property -> value and not value -> property :)
There was a problem hiding this comment.
makes sense! I'll set it to path "/foo": ... and at root: ..., does it make sense? @mobileka
There was a problem hiding this comment.
or even better path "/": ...
mobileka
approved these changes
Jun 2, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.