-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: MsSql support #1610
base: beta
Are you sure you want to change the base?
Feat: MsSql support #1610
Conversation
@Angelelz I guess we should not include RQB in first iteration for MSSQL. So it can be another PR scope, same as |
Hello, Thank you for the time you devote to this dialect. I can not wait to see him :) |
No idea why the tests are not passing. They run well locally. Any idea @dankochetov ? |
Some features have been postponed to later PRs, the scope of this one is already huge as it is.
|
…ql does that for us
It seems this PR has conflicts. Do they have to be resolved before or after the review? |
When will this be good to go? Looking to use Drizzle as our ORM but all DB within the org are MSSQL in Azure. |
Can say that as soon as this gets merged, we are immediately migrating from prisma/sequelize at my org! |
Looks like this isn't going to get merged any time soon so will have to go with an alternative solution. Unfortunate. |
The issue is listed as in-progress: https://github.com/orgs/drizzle-team/projects/1?pane=issue&itemId=47747581 |
Is there any kinda timeline on this getting merged? Would really like to use Drizzle at work but we're stuck on mssql |
I definitely get the never ending priorities for the team, is there anything we in the community can do to assist in moving this forward? Maybe just the orm functionality released in a beta branch so we can assist in the review while the drizzle kit work is pending? I have manually compiled this PR and tested it extensively over the past few months to much success. I'd have no problem putting money where my mouth is so I'm not asking for something for nothing in return, I'd be happy to bump up my monthly sponsorship or shooting over a one-time payment and I hope others would consider doing so as well to get this functionality into this fine code base. |
This comment was marked as spam.
This comment was marked as spam.
@scottrupprecht Maybe this is something you should take to the discord channel: https://discord.gg/tCe773yFeZ |
My company is starting a new major project soon, and I'd love to use this over Prisma. However, we only use MSSQL. It looks like there hasn't been any progress in ~5 months, could we please get an update on whether this is going to be merged in the near future? 🥺 |
Latest update afaik, found on Discord (permalink):
|
RLS info #2450 (comment)
|
This is still not related to MSSQL, please stop referencing that thread. |
Any update on this feature, or a general timeline? The team I am working on is hoping to switch to a newer typescript api framework, but we need mssql support to make this switch. It would be amazing to use drizzle, and hope this feature comes out soon! |
I am also starting a project for my company and it would be great if I could just start using drizzle as opposed to making stuff by hand and then going through the pain of porting everything to drizzle. |
For anybody else who is looking for a good mssql compatible ORM but can't wait for drizzle to add support, my org ended up using kysely and have been very happy with it. It has a companion code gen tool that can introspect types from the database, making setup straightforward. We initially looked into using drizzle but could not for obvious reasons. |
The PR has been updated to resolve conflicts and use the new structures/features of the library. |
Is no one going to respond to @Angelelz? next steps are needed. |
In my opinion, they are waiting, hoping that a sponsor might come forward. Right now, it’s not profitable for them. |
Just to put this out there. This is a 40k+ line PR, and this is only half of what is needed to support mssql. The team will do its best but remember that drizzle-kit support will be needed before this is merged. This PR is only for the ORM side. Mssql requires new syntax to introspect, generate migrations, support the studio, and other drizzle-kit stuff. My understanding is that the team will take care of that part. |
great, thanks a lot for all this effort it would be great to have an issue with the remaining tasks, so we can track it, and it would help everybody understand what's still missing |
This PR aims to close #585.
The initial implementation and the first couple of tests are implemented. I will update this description with the status of the implementation.
Initially the only supported driver will be
node-mssql
.There is still a lot to do:
Merge
support (to do upsert type of functionality)$onUpdate