[postgres-kit] Pass ssl and max connection options to postgres #3936
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass ssl and max connection options to postgres.
ssl- Needed if using Drizzle with a server that enforces ssl. This PR allows using url & ssl, instead of having to split url into host, port, username, password, database just to be able to pass ssl as a parameter to postgres.max- Don't know what the story behindmax: 1here is, but I had to set max to 2, otherwisedrizzle-kit pushwould get stuck pulling database schema from Supabase pooler (with enforce ssl enabled). Having max: 1 first and ...credentials afterwards allows overriding max from drizzle.config.ts which solved that issue.There would be plenty more options to add, see https://www.npmjs.com/package/postgres#connection-details
Might be worth it changing the other pg connections in connections.ts to use the same pattern. I couldn't test those so didn't touch them. Also unsure if those other packages would support the same set of connection options.