Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor CMAKE issues #2144

Closed
eniv opened this issue Aug 31, 2024 · 5 comments
Closed

Minor CMAKE issues #2144

eniv opened this issue Aug 31, 2024 · 5 comments

Comments

@eniv
Copy link
Contributor

eniv commented Aug 31, 2024

CMAKE find_package QUIET attribute is not respected by cmake_modules/FindJsoncpp.cmake
More specifically, it is violated by message(STATUS "jsoncpp version:" ${jsoncpp_ver})
This is very minor.

@eniv
Copy link
Contributor Author

eniv commented Nov 7, 2024

Changed the title to minor CMAKE issues.
I also ran into this if using CMAKE 3.31.0 and later:

CMake Deprecation Warning at build/ext/drogon/build/install/lib/cmake/Drogon/ParseAndAddDrogonTests.cmake:20 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell

@eniv eniv changed the title CMAKE find_package QUIET attribute is not respected by cmake_modules/FindJsoncpp.cmake Minor CMAKE issues Nov 7, 2024
@eniv
Copy link
Contributor Author

eniv commented Nov 26, 2024

Would it be possible to integrate the fixes to those issues in the next version such that integrating drogon will not pollute CMAKE's output?

@an-tao
Copy link
Member

an-tao commented Nov 26, 2024

Hi, thanks for your feedback, would you like to submit a PR to fix this?

@eniv
Copy link
Contributor Author

eniv commented Nov 26, 2024

Sure: #2213
I also included a fix to #2208 in a separate commit

an-tao pushed a commit that referenced this issue Nov 26, 2024
…est with gcc12.3 when building with shared libs (#2208) (#2213)

* Respect find_package QUIET

* Add policy_max to cmake_minimum_required
Avoid deprecation warning introduced by cmake 3.31

* Add missing DROGON_EXPORT
@eniv
Copy link
Contributor Author

eniv commented Nov 26, 2024

Fixed in #2213

@eniv eniv closed this as completed Nov 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants