Support presto Decimal, Date and Timestamp types #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 95.71% 95.47% -0.25%
==========================================
Files 14 14
Lines 1422 1457 +35
Branches 147 149 +2
==========================================
+ Hits 1361 1391 +30
- Misses 40 44 +4
- Partials 21 22 +1
Continue to review full report at Codecov.
|
devinstevenson
force-pushed
the
support-presto-decimal-type
branch
2 times, most recently
from
bf5a6fd to
26e948f
Compare
alter col_type renaming for decimal to not clobber other col_types use Presto types for sqlalchemy _type_map update tests for new type handling add date column for tests fix missing comma use raw regex pattern change doc
devinstevenson
force-pushed
the
support-presto-decimal-type
branch
from
26e948f to
85ebb50
Compare
|
Devin Stevenson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jingw.
I added support on Presto for decimal, date, and timestamp presto types. I also modified the tests to include a date type. The Travis CI test failed on python 3.6 seems to be a Travis CI issue. The tests passed on all other versions of python.