Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Convert hook_element_info. initial commmit #58

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

andriyun
Copy link
Member

@andriyun andriyun commented Feb 1, 2016

Issue: #20

Initial commit done!
Need review:

  • common things
  • all js libraries added in dummy mode. Need to create issue to convert it
  • process and preprocess methods added in dummy mode. How we will work on it?
  • processGmapControl method is common for few elements. I don't understand how we can implement it in single place. Any idea?

}

}
?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need ?> in the end.

@ddrozdik
Copy link
Member

ddrozdik commented Feb 1, 2016

Module for 7 version has hook location_element_info() which provide elements with process functions. Process function for location_element provides list of fields, like Location name, Street, Latitude, Longitude and other fields returned by hook_location_api.

But I see that you have created different elements for each field. We should have something similar. Please investigate module more detailed. This ticket should contain a class which will provide fields, and they will be available on the content type settings page

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants