Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Menu a11y fixes #295

Open
soniktrooth opened this issue Oct 28, 2016 · 2 comments
Open

Menu a11y fixes #295

soniktrooth opened this issue Oct 28, 2016 · 2 comments
Assignees
Milestone

Comments

@soniktrooth
Copy link
Contributor

soniktrooth commented Oct 28, 2016

We surfaced some a11y fixes for menus in EECS particularly to do with role="menu" and role="menuitem" which are actually meant for web apps. We should remove these from the theme functions they are currently in.

see https://kalamuna.atlassian.net/browse/EECS-510

@soniktrooth soniktrooth added this to the 7.x-3.3 milestone Oct 28, 2016
@soniktrooth soniktrooth self-assigned this Oct 28, 2016
@andrewmallis
Copy link
Member

It would be interesting to see what the a11y people at UCB do say about our standard bootstrap patterns for kalatheme menus.

http://sinberbest.berkeley.edu is a UCB property. Perhaps we can ask for a review of that site?

@soniktrooth
Copy link
Contributor Author

@andrewmallis I already know what they would say. The fixes that I will make with this issue will bring us inline with vanilla Bootstrap, however there are still some issues with roles. I have doubts that we will have the bandwidth to address too much of this given that BS 4 is close and efforts really need to be concentrated on D8.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants