-
-
Notifications
You must be signed in to change notification settings - Fork 27
Makes classes
compatible with mypy
1.2
#487
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
@sobolevn just need a little of your help here with the errors! |
This test needs some love. Right now it is in a semi-broken state.
Can be just ignored.
Can be just ignored. |
b22e008
to
13d3f44
Compare
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 103 106 +3
Branches 18 17 -1
=========================================
+ Hits 103 106 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
13d3f44
to
3c1de4f
Compare
I need to dig more deep to see why this expected error is not being raised anymore:
|
Updated #483 to have also mypy^1.2.0. Can you guys either cherry-pick it here or review after this one is merged |
Sure! |
You can do the same for |
Added dry-python/returns#1605 |
Hello. How are things going? If you wish, I can try to fix it. |
@guitvcer you are very welcome to create a PR with new mypy version :) |
Makes
classes
compatible withmypy
1.2Checklist
CHANGELOG.md