Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

.dev file extension is used as version number #284

Closed
EyMaddis opened this issue Jan 22, 2021 · 3 comments
Closed

.dev file extension is used as version number #284

EyMaddis opened this issue Jan 22, 2021 · 3 comments

Comments

@EyMaddis
Copy link

I have react-native in my devDependencies (since this is also a web app) and therefore renamed the patch file react-native+0.62.2.dev.patch.
However, this now leads to warnings everytime I install packages (yarn in my case).


Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    react-native@0.62.2.dev

  applied to

    react-native@0.62.2
  
  At path
  
    node_modules/react-native

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package react-native

  to update the version in the patch file name and make this warning go away.

It seems that patch-package thinks that .dev is part of the version number.

@EyMaddis
Copy link
Author

Ahh... somebody already made a PR for that: #224
I will close this ticket once this landed

@felixmosh
Copy link

Is it possible to review #224 pr?

@ds300
Copy link
Owner

ds300 commented Feb 28, 2021

Thanks the report! ❤️ This was fixed in v6.3.0

@ds300 ds300 closed this as completed Feb 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants