Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore ".dev" suffix when deciding on package version mismatch #224

Closed
wants to merge 1 commit into from
Closed

Ignore ".dev" suffix when deciding on package version mismatch #224

wants to merge 1 commit into from

Conversation

pdcastro
Copy link

Do you have time/desire to try fixing that? No worries if not, I can get around to it this week.
#202 (comment)

@ds300, I guess you haven't had the time either. :-) I am resubmitting that PR (not possible to reopen the old one because the branch was rebased) because my users are reporting a problem (ENOENT) with the update-notifier dependency. I see this was solved in patch-package v6.2.1 by removing the dependency altogether (great!) but I am stuck at patch-package v6.1.x because of issue #201 which is "sufficiently resolved" by this PR, according to my testing. I understand it is not the perfect fix, but it also seems harmless and it solves my problem, so could we get this merged as it is and you can then do the better fix later on? :-) Thanks!

@pdcastro
Copy link
Author

could we get this merged as it is and you can then do the better fix later on?

By the way, this is why I also submitted issue #203 :-)

@ds300
Copy link
Owner

ds300 commented Feb 27, 2021

Thanks for this! 🙌 Apologies it took me so long to get around to it. The root of the problem is the getPackageDetailsFromPatchFilename function which I fixed in this commit: a3a351e so I'm going to close this. I very much appreciate you raising the issue and offering a fix ❤️

@ds300 ds300 closed this Feb 27, 2021
@ds300
Copy link
Owner

ds300 commented Feb 27, 2021

the fix was just released in v6.3.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants