Add --ignore-errors option #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ds300 What's your take on that? |
|
Hey, thanks for the contribution! ❤️ Sorry it took me so long to get around to this. This change makes sense. I'd even go as far as to say it should be the default behaviour. In fact I'm struggling to see why it shouldn't be the only behaviour. So I'll merge this, remove the cli option, and add some tests. 🙏🏼 |
|
follow-up commits in case anybody is interested 4a17770...0e087bd |
|
This was just released in v6.3.0 |
This was referenced Mar 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199.
The program will exit only after it tries to apply all of the patches.
However, instead of breaking the default behaviour I propose an additional opt-in flag
--ignore-errors.Error messages still visible.
Return code logic unchanged (respecting
shouldExitPostinstallWithError).