Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

make work with pnpm #252

Merged
merged 1 commit into from
Mar 2, 2021
Merged

make work with pnpm #252

merged 1 commit into from
Mar 2, 2021

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Aug 24, 2020

No description provided.

@DrSensor DrSensor mentioned this pull request Sep 17, 2020
Closed
@idkjs
Copy link

idkjs commented Oct 31, 2020

Any plans to merge this?

@biowaffeln
Copy link

@idkjs in the meantime you could use patch-package to patch patch-package.

@niieani
Copy link

niieani commented Jan 26, 2021 •
edited
Loading

@biowaffeln unfortunately that doesn't work. patch-package crashes before it gets a chance to patch itself 🤷
I had to switch to yarn 2 for the time being :(

@emanueleDiVizio
Copy link

emanueleDiVizio commented Jan 27, 2021 •
edited
Loading

I see this has been approved, is there any roadmap to release this on npm? It'd be grand to keep using patch-package in our project as we migrate to pnpm!

@niieani
Copy link

niieani commented Feb 6, 2021 •
edited
Loading

@emanueleDiVizio I'm not a maintainer, so my approval doesn't really mean anything :) But I did review and test the change locally, and it seems legit 👍.

@ds300 ds300 merged commit 3c0883a into ds300:master Mar 2, 2021
@ds300
Copy link
Owner

ds300 commented Mar 2, 2021

Thanks for this! 🙏🏼 Sorry it took me so long to get around to merging.

@ds300
Copy link
Owner

ds300 commented Mar 2, 2021

This was just released in v6.4.3

@milahu
Copy link
Contributor Author

milahu commented Mar 2, 2021

Sorry it took me so long to get around to merging.

190 days for 3 lines of code : D *scnr*

@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@milahu milahu mentioned this pull request May 11, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@niieani niieani niieani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@milahu @idkjs @biowaffeln @niieani @emanueleDiVizio @ds300