Add --error-on-warn flag to exit 1 on warnings

[mvargeson]

This addresses the scenario described in #314. I'm not sure if this is a desirable addition to the project but we are running into issues with automated dependency updates not taking into consideration patched dependencies and would like to prevent these warnings from making it onto our main branch.

The change is pretty minimal and follows the pattern that the --error-on-fail flag took. This changes the process.exit logic at the end of applyPatchesForApp and gives that function a new parameter, shouldExitWithWarning that looks at the flag boolean value. There are a couple of questions that I have:

1. Does shouldExitWithWarning make sense? I may be misunderstanding terminology in variable names so please feel free to suggest something better.
2. Do I need to consider environmental variables similar to --error-on-fail? I did not fully understand if that would be a good idea here.
3. Would it be better to try to introduce a single flag that would take both warning and failures levels into account before deciding the exit code? Again, I mostly tried to just stick with the change that was the least amount of change but open to something else here.

Feel free to close out if not interested in this addition or request changes if this doesn't seem like the correct implementation.

[jraoult]

I would love to see it landing 👏. @ds300 any chance you would consider this?

[jraoult]

@mvargeson have you published your fork on NPM by any chance? I really want this and I'm don't think it will be merged upstream anytime soon (the last activity I can see on this repo was in March).

[mvargeson]

@jraoult I haven't but feel free to take the branch from my fork and do so. If you prefer a more simple way to use, it may be easiest to create branch on your own fork, apply the git patch I linked below, and then make use of that directly in your package.json dependencies.

Alternatively, if you only want the min change required then here is the branch: mvargeson:mvargeson/issue-314/error-on-warn-min-change.

Here is the git patch: 0001-Exit-on-warning-and-errors.patch.tar.gz.

Here is the patch to the installed node_modules dist file although you can't really use patch-package on itself so probably no terribly useful: patch-package+6.4.7.patch.tar.gz.

[jraoult]

@mvargeson thanks for your reply.

The reason I'm asking about publishing to NPM is that this project needs a build step since it is written in TS and my good old legacy yarn is not able to get that build at install time properly, so the git dependency style won't work for me.

I'll publish a fork under my namespace if you don't mind then, it's easier.

[mvargeson]

There have been no updates to this repository in over a year; closing this out. Feel free to reopen if the project is revived at any point.

[orta]

I think this PR as-is is reasonable, I can see the idea of switching to a --fail-on=warn or --fail-on=error but I don't think it's compelling enough to warrant breaking existing flows, doing server bumps etc. So, lets have this in 👍🏻

[ds300]

This was just released in v6.5.0! Thanks for your contribution 🙏🏼 🎉

[jraoult]

Oh my 🎉 I'm sadly not using patch-package anymore, but my 2021 self is thanking you. It probably means the original issue can be closed as solved as well @orta (cf. #314)