dereference symlink on copying .npmrc and .yarnrc in makePatch #402
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team was facing problem on making patch, in which the package is hosted in private registry. We have noticed that #152 has already handle such scenario, but we are still facing error with message similar as #300
After checking, we notice that since our
.npmrc
is symlink to somewhere else (as to facilitate switch registry), we use symlink which is copied into the tmp folder during make patch, and thus the symlink cannot resolve.This PR uses node fs
copySync
dereference
flag (https://github.com/jprichardson/node-fs-extra/blob/master/docs/copy-sync.md) to dereference the symlinkThanks