Make the eye dropper work with more than one screen #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the eye dropper was hardcoded to only use the primary screen. This commit changes that behaviour to essentially use the screen the mouse is located on and re-take the screenshot as well as move the eye dropper window when the mouse moves to a different screen.
|
Thanks! I think that avoiding adding |
|
Sure, that's easy enough. Implemented in c44c6c0. |
|
Thanks again! I'm gonna close and reopen the pr to see if I can get the CI to work properly this time |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thank you very much for the great library! It was very helpful for a recent project of mine.
I noticed that the eye dropper was hardcoded to only use the primary
screen.
In this PR, I tried to change that behaviour to essentially use the screen
the mouse is located on instead and re-take the screenshot as well as move
the eye dropper window when the mouse moves to a different screen.
Unfortunately, this change depends on winforms code for the
System.Windows.Forms.ScreenAPI. It may be possible to instead replace that with WpfScreenHelper which seems to be a little more lightweight. Not sure what your preferences are here.Let me know if you need any more changes to be done.
Cheers,
Benni