Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Complete Azure DevOps CI Conversion #147

Merged
merged 16 commits into from
May 13, 2020
Merged

Complete Azure DevOps CI Conversion #147

merged 16 commits into from
May 13, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented May 13, 2020 •
edited by johlju
Loading

Pull Request (PR) description

This PR completes the Azure DevOps CI conversion by merging the changes from the dev branch to `master.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

johlju and others added 16 commits May 13, 2020 17:47
@johlju @X-Guardian
Changes to SecurityPolicyDsc (#136)
4593089 
- Resolved custom Script Analyzer rules that was added to the test framework.
@X-Guardian
SecurityPolicyDsc: Move Change Log to CHANGELOG.md and Add Build/Code…
990daf0 
… Coverage Badges (#133)

* Updae CHANGELOG, README and PULL_REQUEST_TEMPLATE

* Fix README build status badges

* Update CHANGELOG.md

* Updated CHANGELOG 2.10 release heading level

* Updated CHANGELOG heading

* Update CHANGELOG.md

* Update CHANGELOG
@ccunning @X-Guardian
Issue 126 add cim identity options (#142)
6ff6dc2 
- Changes to SecurityPolicyDsc:
  - Added support for more SDDL SID constants (issue #126)
    - Added functions to convert identity to and from SDDL SID constants
    - Changed Format-RestrictedRemoteSAM to use new function to create strings with additional SDDL SID constants
    - Changed ConvertTo-CimRestrictedRemoteSam to use new function to accept more possible SDDL SID constants
    - Changed ConvertTo-CimRestrictedRemoteSam to skip CimInstance creation if no valid Identity was found
@X-Guardian
SecurityPolicyDsc: Add PowerShell DSC Resource Help Files (#139)
119efde
@X-Guardian
SecurityPolicyDsc: Add Property Descriptions to the Schema MOF files …
862d4da 
…and update README (#137)
@X-Guardian @johlju
Add DSCResource READMEs (#138)
bfc41ad 
Co-authored-by: Johan Ljunggren <johlju@users.noreply.github.com>
@X-Guardian
Convert CI
f7e3694
@X-Guardian
Update tests
a55f5eb
@X-Guardian
Update tests
09a23d5
@X-Guardian
Update tests
c31a9e5
@X-Guardian
Update tests
c816a03
@X-Guardian
Update tests
6060f83
@X-Guardian
Update tests
c8073ed
@X-Guardian
Update tests
c577147
@X-Guardian
Update changelog
7e67209
@X-Guardian
Update SecurityPolicyDsc.psd1
734ebd4
@X-Guardian X-Guardian marked this pull request as ready for review May 13, 2020 17:05
@X-Guardian X-Guardian requested a review from johlju May 13, 2020 17:05
@X-Guardian X-Guardian added the needs review The pull request needs a code review. label May 13, 2020
johlju
johlju approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels May 13, 2020
@johlju
Copy link
Member

johlju commented May 13, 2020

It is okay to merge @X-Guardian

@X-Guardian X-Guardian merged commit e35a55e into master May 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@X-Guardian @johlju @ccunning