Wrap status id in helper type #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wrapper type ensures that the status id cannot accidentially be compared to some other string that represents something entirely else. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
I'd like to see some tests come with this, and we should also consider other types which should be set up this way, such as account IDs, media IDs, etc. |
|
Yes, we should definitively also wrap the other types. Should I add changes for this in this PR or open seperate ones? |
|
Let's keep it together in one place |
|
This conflicts with #39 probably, so I'd rather wait for that other PR. |
Merged
|
Superseded by #50 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper type ensures that the status id cannot accidentially be compared to some other string that represents something entirely else.