Add "poll" notification support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just added another notification type I discovered missing: follow request for clients which require approval. |
|
Thanks for this, a full comb-through of all the types to make sure it matches with the current spec is in progress. I appreciate your help with that. |
|
Please note that these are not the only notification types possible, and that the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
This is the minimal patch needed to avoid the issue. I was expecting to parse the poll data, but that seems to be hidden behind a "..." in the notification content itself by the API.
I would have also added tests, but this is trivial and I couldn't figure out where.