fix: recursive depth limit in setup call #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need this. 1) the path specified in the MANIFEST doesn't even exist. and 2) the package data is specified already in setup(). You can verify this by running pip install, and tree_shap.h is included in the wheel even without the MANIFEST
dsgibbons
approved these changes
May 22, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50.
Changes
setup()to continue if any of the test optional dependencies fail to install. Also the previous logic was very brittle/inaccurate and cause issues like Cannot install package: CUDA Error - Add Fall back option to CPU #50.MANIFEST.infile, it's not necessary because 1) the file path specified in the MANIFEST doesn't even exist, and 2) the package data is specified already in setup(). You can verify this by running pip install, andtree_shap.his included in the wheel even without the MANIFEST.