Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix further NumbaDeprecationWarnings: migrate from jit to njit #68

Merged
merged 1 commit into from
May 25, 2023

Conversation

connortann
Copy link
Collaborator

Original issue: shap#2909

PR #9 attempted to solve the issue by explicitly specifying nopython=False, but inadvertently introduced other Deprecation warnings as nopython mode is being removed entirely.

The recommendation from numba is to disable the object mode behaviour, by setting nopython=True or equivalently using njit.

@connortann connortann changed the title Fix NumbaDeprecationWarning: migrate from jit to njit Fix further NumbaDeprecationWarnings: migrate from jit to njit May 25, 2023
@connortann connortann marked this pull request as ready for review May 25, 2023 09:07
@connortann connortann requested a review from dsgibbons May 25, 2023 09:08
@connortann
Copy link
Collaborator Author

On the previous PR, I didn't check that the warnings were fixed on python 3.10. Checking the logs of this PR, those warnings seem to be properly fixed now.

The only Numba warnings that remain relate to deprecated types; I opened a separate issue for that: #70.

@connortann connortann added the bug Something isn't working label May 25, 2023
@connortann
Copy link
Collaborator Author

connortann commented May 25, 2023

@dsgibbons would you be able to review?

The numba warnings seem to be of relatively high interest judging by the traffic, so it would be fab to get this issue fixed fully.

Copy link
Owner

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connortann thank you for bringing the increased traffic to my attention. I read over https://numba.readthedocs.io/en/stable/reference/deprecation.html as I was not too familiar with njit. Your PR looks good and it doesn't seem to have broken any tests that were broken before.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants