fix: remove numpy deprecations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove numpy deprecations in root shap fix: remove numpy deprecations in nested dir
There was a problem hiding this comment.
LGTM in general.
But there seems to be a couple more (in the notebooks) that the original PR missed. Shall we fix these too?
Secondly, I noticed that np.bool8 is also getting deprecated in numpy 1.24, I thought we might take this chance to also fix it here if it's not too troublesome.
|
There's >>> import numpy as np; np.__version__
'1.24.3'
>>> np.object
<stdin>:1: FutureWarning: In the future `np.object` will be defined as the corresponding NumPy scalar.
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/xxx/forks/shap/venv/lib/python3.8/site-packages/numpy/__init__.py", line 305, in __getattr__
raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'object'.
`np.object` was a deprecated alias for the builtin `object`. To avoid this error in existing code, use `object` by itself. Doing this will not modify any behavior and is safe.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
|
dsgibbons
force-pushed
the
remove-np-deprecations
branch
from
579c343 to
c21c80b
Compare
|
Good spot! I think that's all of them |
55 tasks
|
Just wanted to mention / link a couple more related issues about the same topic:
|
This was referenced May 14, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warnings as per shap#1890