Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix manipulation of JsxSelfClosingElement #1410

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

odiak
Copy link
Contributor

@odiak odiak commented May 10, 2023

While I investigating #1409, I found suspicious code from stack trace.
Because it works as expected after fixing there, I made this pull request.

@odiak
Copy link
Contributor Author

odiak commented May 10, 2023

I also found some similar code pieces, though I'm not sure if they cause error.

while (!currentNodeChildren.done)
this.straightReplace(currentNodeChildren.next(), newNodeChildren.next(), newSourceFile);

while (!currentChildren.done)
this.helper.handleForValues(this.straightReplacementNodeHandler, currentChildren.next(), newChildren.next(), newSourceFile);

while (!currentChildren.done)
this.helper.handleForValues(this.straightReplacementNodeHandler, currentChildren.next(), newChildren.next(), newSourceFile);

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant