Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature storage sqlserver #467

Merged
merged 6 commits into from
Nov 5, 2023
Merged

Conversation

wooln
Copy link
Contributor

@wooln wooln commented Oct 11, 2023

Import gorm.io/driver/sqlserver@v1.1.2 to implement SqlServer storage for dtm server.
NOT implement dtmcli go client SqlServer barrier.

#472

@wooln wooln force-pushed the feature-storage-sqlserver branch 7 times, most recently from 97160b8 to a4ac3ca Compare October 19, 2023 09:49
dtmsvr/storage/sql/sql.go Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #467 (e233895) into main (dedf72e) will decrease coverage by 0.12%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   96.05%   95.94%   -0.12%     
==========================================
  Files          57       57              
  Lines        4212     4239      +27     
==========================================
+ Hits         4046     4067      +21     
- Misses        120      124       +4     
- Partials       46       48       +2     
Files Coverage Δ
client/dtmcli/dtmimp/utils.go 93.78% <100.00%> (+0.57%) ⬆️
dtmsvr/storage/registry/registry.go 75.00% <ø> (ø)
dtmsvr/storage/sql/sql.go 97.41% <100.00%> (-1.25%) ⬇️
dtmutil/db.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wooln wooln force-pushed the feature-storage-sqlserver branch 2 times, most recently from 952ced4 to a1a26ca Compare October 19, 2023 13:14
@wooln wooln marked this pull request as ready for review October 19, 2023 13:20
@wooln wooln force-pushed the feature-storage-sqlserver branch from a1a26ca to b210ad7 Compare October 24, 2023 01:56
dtmsvr/storage/sql/sql.go Outdated Show resolved Hide resolved
client/dtmcli/dtmimp/consts.go Outdated Show resolved Hide resolved
client/dtmcli/dtmimp/db_special.go Outdated Show resolved Hide resolved
client/dtmcli/dtmimp/utils.go Outdated Show resolved Hide resolved
dtmsvr/config/config.go Outdated Show resolved Hide resolved
@wooln wooln requested a review from yedf2 November 4, 2023 14:35
@yedf2 yedf2 merged commit 14d0eaf into dtm-labs:main Nov 5, 2023
@wooln wooln deleted the feature-storage-sqlserver branch November 5, 2023 11:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants