Skip to content

Support static member functions & c++ constructor of shared type #1430

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Jan 31, 2025

Implement #447 (comment)

  • cxx side static member functions
  • export as static member functions in rust side as well
  • rust side static member functions
  • when returns Self with #[Self = ], it defined as constructor in c++

Close #1419, fix #464

@yujincheng08 yujincheng08 force-pushed the static branch 3 times, most recently from 7127d9d to 7485943 Compare January 31, 2025 17:15
@yujincheng08 yujincheng08 marked this pull request as ready for review January 31, 2025 17:15
@yujincheng08 yujincheng08 force-pushed the static branch 2 times, most recently from 7150b2e to fc2504a Compare January 31, 2025 17:34
@yujincheng08 yujincheng08 changed the title Support static member functions Support static member functions & constructor of shared type Feb 1, 2025
@yujincheng08 yujincheng08 changed the title Support static member functions & constructor of shared type Support static member functions & c++ constructor of shared type Feb 1, 2025
@yujincheng08 yujincheng08 changed the title Support static member functions & c++ constructor of shared type Support static member functions Feb 1, 2025
@yujincheng08 yujincheng08 force-pushed the static branch 4 times, most recently from fd46613 to 094a7be Compare February 2, 2025 09:13
@yujincheng08 yujincheng08 changed the title Support static member functions Support static member functions & c++ constructor of shared type Feb 2, 2025
@yujincheng08 yujincheng08 force-pushed the static branch 2 times, most recently from 0e8a115 to e270c9c Compare February 2, 2025 10:29
@yujincheng08
Copy link
Contributor Author

@dtolnay any chance this PR gets review?

@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

1 similar comment
@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static member functions Specify name of class that static method is defined on
1 participant