Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow wildcard argument names. #159

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Allow wildcard argument names. #159

merged 1 commit into from
Apr 27, 2020

Conversation

jgalenson
Copy link
Contributor

This adds support for wildcard variable names by internally giving them unique names.

Fixes #154.

This seems simpler than trying to ensure we catch all uses of an ident named "_" and naming them appropriately.

@jgalenson
Allow wildcard argument names.
ba67607 
This adds support for wildcard variable names by internally giving
them unique names.
dtolnay
dtolnay approved these changes Apr 27, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Exactly the implementation I had in mind.

@dtolnay dtolnay merged commit d6c5219 into dtolnay:master Apr 27, 2020
@jgalenson jgalenson deleted the underscore branch April 27, 2020 23:48
@dtolnay
Copy link
Owner

dtolnay commented Apr 28, 2020

Published in 0.2.12.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow wildcard argument names in extern function signature
2 participants
@jgalenson @dtolnay