Fix README.md to match the files linked just below. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Apr 3, 2020
There was a problem hiding this comment.
Thanks for the PR!
I think I would prefer to keep this as originally written. This is the first code snippet in the readme, and so I would prefer to keep it as focused on the important concepts as possible. There is lots more detail filled in by the links for readers who make it that far.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit confused about how this snippet in
README.mdmatched the .h and .cc files below. I figured it out as soon as I looked at the realmain.rsbut here's a tiny PR to keep them in sync.