Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make a single wr.write_all() call, even for negative integers. #8

Closed
wants to merge 3 commits into from
Closed

Make a single wr.write_all() call, even for negative integers. #8

wants to merge 3 commits into from

Conversation

SimonSapin
Copy link
Contributor

No description provided.

dtolnay
dtolnay reviewed Aug 29, 2017
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I merged this in 220a868 and f5d656f (without the first commit) because I want to match libcore's implementation except where necessary to adapt it to itoa's interface.

@dtolnay dtolnay closed this Aug 29, 2017
@dtolnay
Copy link
Owner

dtolnay commented Aug 29, 2017

Published as itoa 0.3.3.

@dtolnay dtolnay mentioned this pull request Aug 29, 2017
Merged
@SimonSapin
Copy link
Contributor Author

Thanks!

arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#44158 - dtolnay:zero48, r=sfackler
a5e3484 
Use a byte literal ASCII 0 instead of its decimal value

@SimonSapin noticed this in dtolnay/itoa#8.
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#44158 - dtolnay:zero48, r=sfackler
be0ac01 
Use a byte literal ASCII 0 instead of its decimal value

@SimonSapin noticed this in dtolnay/itoa#8.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @dtolnay