Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Respect None-delimited group when parsing unary expr #1543

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Dec 11, 2023

Example input: $expr.method() where expr is &self.

Before: incorrect, this is &(self.method())

Expr::Reference {
    expr: Expr::MethodCall {
        receiver: Expr::Path {
            path: Path {
                segments: [
                    PathSegment {
                        ident: "self",
                    },
                ],
            },
        },
        method: "method",
    },
}

After: correct. (&self).method()

Expr::MethodCall {
    receiver: Expr::Group {
        expr: Expr::Reference {
            expr: Expr::Path {
                path: Path {
                    segments: [
                        PathSegment {
                            ident: "self",
                        },
                    ],
                },
            },
        },
    },
    method: "method",
}

@dtolnay dtolnay merged commit 5693152 into master Dec 11, 2023
@dtolnay dtolnay deleted the unarygroup branch December 11, 2023 02:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant