Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

⚡️ Mark all arbitraries as side-effect free #5771

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Mar 1, 2025

Description

Fixes #5560

So far we did it via a post build script as we strip comments in the build process configured with tsc.

Results: here.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ...
  • Impacts: ...

Copy link

changeset-bot bot commented Mar 1, 2025

🦋 Changeset detected

Latest commit: b95294a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fast-check Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 1, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5771

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5771

fast-check

npm i https://pkg.pr.new/fast-check@5771

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5771

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5771

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5771

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5771

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5771

commit: b95294a

Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 A preview of the new documentation is available at: http://67c34d5ad94dff3f9c1134ec--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (9723dcf) to head (b95294a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5771   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         212      212           
  Lines       10057    10057           
  Branches     2670     2671    +1     
=======================================
  Hits         9527     9527           
  Misses        530      530           
Flag Coverage Δ
unit-tests 94.73% <ø> (ø)
unit-tests-18.x-Linux 94.73% <ø> (ø)
unit-tests-20.x-Linux 94.73% <ø> (ø)
unit-tests-22.x-Linux 94.73% <ø> (ø)
unit-tests-latest-Linux 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 6de0e98 into main Mar 1, 2025
73 checks passed
@dubzzz dubzzz deleted the mark-all-arbitraries-side-free branch March 1, 2025 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighter bundles with no-side-effect
1 participant