Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding transaction support in md #463

Merged
merged 1 commit into from
Oct 15, 2024
Merged

adding transaction support in md #463

merged 1 commit into from
Oct 15, 2024

Conversation

matsonj
Copy link
Collaborator

@matsonj matsonj commented Oct 15, 2024

Cleaning up readme in preparation for adding this documentation to the dbt docs.

@matsonj matsonj requested a review from jwills October 15, 2024 22:05
@matsonj
Copy link
Collaborator Author

matsonj commented Oct 15, 2024

Wondering aloud (+@guenp) if we should format these docs to match the dbt page exactly for ease of maintenance. I've re-organized slightly on the dbt side but I am not sure if I should.

Copy link
Collaborator

@jwills jwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamping

@matsonj
Copy link
Collaborator Author

matsonj commented Oct 15, 2024

Wondering aloud (+@guenp) if we should format these docs to match the dbt page exactly for ease of maintenance. I've re-organized slightly on the dbt side but I am not sure if I should.

On second thought, these are aiming for different goals. Will need to keep them slightly differently, although only just.

@matsonj matsonj merged commit 9b34a9d into master Oct 15, 2024
32 of 33 checks passed
@matsonj matsonj deleted the update-readme branch October 15, 2024 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants