Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document Postgres attachment for read/write #476

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dumkydewilde
Copy link
Contributor

Currently the documentation only shows using Postgres as a plugin. This uses the POSTGRES_SCANNER implementation of DuckDB, however using the Postgres extension as an attachment allows for both reading and writing. Though the current implementation of attachments in DuckDB seems to be intended for file-based attachments, this functionality works for postgres to using a Postgres DSN.

Potentially additional implementation changes can be made to either improve the attachment functionality or even remove the Postgres plugin in favour of the attachment implementation, but I'll leave that up to a discussion. For now I think a simple documentation change can save people a lot of headaches.

Copy link
Collaborator

@jwills jwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-- thank you!

@jwills jwills merged commit a5be67a into duckdb:master Nov 18, 2024
29 of 31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants