Skip to content

Bundle jemalloc with JDBC Driver #116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 10 commits into from

Conversation

brianwyka
Copy link
Contributor

Fixes #63

Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@brianwyka
Copy link
Contributor Author

Thanks @lnkuiper ! Do you think this will make it into 1.2.0 release?

@lnkuiper
Copy link
Contributor

lnkuiper commented Jan 6, 2025

@brianwyka It's not up to me to decide but if this gets merged within ~1 week or so, it will go into v1.2.0

@brianwyka
Copy link
Contributor Author

Thanks! @hannes , can we get this into 1.2.0 release?

@brianwyka
Copy link
Contributor Author

@lnkuiper , what is the best way to resolve this merge conflict?

@lnkuiper
Copy link
Contributor

Hi @brianwyka, sorry for the inconvenience. Does re-generating the files help? i.e., python3 vendor.py

@brianwyka
Copy link
Contributor Author

Hi @brianwyka, sorry for the inconvenience. Does re-generating the files help? i.e., python3 vendor.py

I'll give that a try.

@brianwyka
Copy link
Contributor Author

Closing this out due to conflicts, replaced by #131

@brianwyka brianwyka closed this Jan 19, 2025
@brianwyka brianwyka deleted the bundle-jemalloc branch January 19, 2025 21:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing jemalloc dependency
3 participants