fix vendor script #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndor.sh before commiting everything
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 106 106
Lines 3598 3599 +1
=======================================
+ Hits 3081 3082 +1
Misses 517 517 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
krlmlr
reviewed
Sep 27, 2023
| @@ -23,5 +27,6 @@ echo "Importing commit $commit" | |||
| echo "R: configure" | |||
| python3 rconfigure.py | |||
|
|
|||
| git checkout vendor.sh | |||
There was a problem hiding this comment.
I see now. We could also check if the Git status is clean here.
There was a problem hiding this comment.
Or selectively commit src/vendor only.
| if [ -z "$1" ]; then | ||
| duckdir=../duckdb | ||
| else | ||
| duckdir=../$1 |
There was a problem hiding this comment.
I'd expect the user to give a directory path relative to the cwd, do we need to move this before the cd and use realpath?
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like the last update vendor script changed last time the vendor script ran 16d50d4#diff-5207f4376418838c90f2fbb73b803096a1b41cae984e1c78af0726977a9331c6. Probably because everything gets added and committed, so the change is silently commited.
Now you can pass the surname of the duckdb repo, but the default is duckdb.
Also, if someone does change the vendor script, the changes are erased when the script is executed to avoid this happening again.
This will fix the broke R scripts on duckdb-main
https://github.com/duckdb/duckdb/actions/runs/6323197765/job/17170295075