Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extensions: Optimize build to remove most exports via SIDE_MODULE=2 #1601

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Jan 22, 2024

Improvement depends a lot on the extensions, can be 0-30%. For example, icu.duckdb_extension.wasm goes from 8.0MB to 6.3MB (uncompressed size)

Improvement depends a lot on the extensions, can be 0-30%. For example,
icu.duckdb_extension.wasm goes from 8.0MB to 6.3MB (uncompressed size)
@carlopi
Copy link
Collaborator Author

carlopi commented Jan 22, 2024

This is the linked PR in spatial: duckdb/duckdb-spatial#234

@carlopi
Copy link
Collaborator Author

carlopi commented Jan 22, 2024

Also adding here, to be addressed in a future PR or at the Emscripten or even standardization level:
duckdb-wasm extensions do not expose their symbol at the JavaScript level, so the exports do not need to have the actual mangled names as export names, but they could have unnamed export names.

EDIT: unnamed is not actually possible, but arbitrary export names.

@carlopi carlopi requested a review from Mytherin January 25, 2024 08:35
@Mytherin Mytherin merged commit 8e4d4bf into duckdb:main Jan 29, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants