Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable broken site reporting & privacy protections toggle when viewing through Duck Player #5664

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

laghee
Copy link
Collaborator

@laghee laghee commented Feb 18, 2025

Task/Issue URL: https://app.asana.com/0/1201870266890790/1209422420805301

Description

We should check for duckplayer url when setting canReportSite

Steps to test this PR

Feature 1

  • Set "Open YouTube Videos in DuckPlayer" to Always
  • Enable "Open DuckPlayer in a new tab"
  • Search for any video and click or enter a URL directly (e.g., https://youtu.be/3ml7yeKBUhc)
  • Confirm that "Report Broken Site" is not showing in the 3-dot/overflow menu
  • Disable "Open DuckPlayer in a new tab" and repeat check
  • Set "Open YouTube Videos in DuckPlayer" to Ask Every Time and repeat check
  • Enable "Open DuckPlayer in a new tab" and repeat check
  • Reset "Open YouTube Videos in DuckPlayer" to Always
  • Use a note-taking or any other external app to open a YouTube link directly and repeat check
  • Disable "Open DuckPlayer in a new tab"
  • Set "Open YouTube Videos in DuckPlayer" to Ask Every Time and repeat check
  • Enable "Open DuckPlayer in a new tab" and repeat check

UI changes

Before After
reportingEnabled after

@laghee laghee changed the title Disable broken site reporting when viewing through Duck Player Disable broken site reporting & privacy protections toggle when viewing through Duck Player Feb 19, 2025
@laghee laghee merged commit 68535d6 into develop Feb 19, 2025
5 checks passed
@laghee laghee deleted the fix/kate/disable-reporting-duckplayer branch February 19, 2025 16:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants