New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Autofill suggestion: hide second line if subtitle empty #5670

Open

cmonfortep wants to merge 1 commit into develop from feature/cristian/autofill/improve_ui_suggestion_entry_point

Contributor

cmonfortep commented Feb 20, 2025 •

edited

Loading

Task/Issue URL: https://app.asana.com/0/1149059203486286/1209453476472064

Description

Hide subtitle when string is empty, making suggestion a single line.

Steps to test this PR

Feature 1

from an api 29 device o no keyboard
select ddg as autofill provider
visit fill.dev on another browser
focus a field to get suggestions
they should show as dropdown
ensure entry point to DDG is single line

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)


          Autofill suggestion: hide second line if subtitle empty

9807d68

Contributor Author

cmonfortep commented Feb 20, 2025

Autofill suggestion: hide second line if subtitle empty #5670 👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

cmonfortep requested a review from CDRussell

February 21, 2025 15:30

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet