-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add support for css,json,markdown parsers #55
Conversation
Hi @ic4l4s9c, thank you for your PR! I appreciate the time and effort you’ve put into contributing to this plugin. could you please provide more context about the changes? For example, what specific improvements or benefits does this PR introduce? are there any examples about this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1048 1073 +25
=========================================
+ Hits 1048 1073 +25 ☔ View full report in Codecov by Sentry. |
@dukeluo, thank you for quick response and a great plugin, here is the breakdown of my changes: This PR focuses of two issues:
Here is the demo repo: If you run
This happens since preprocess function of this plugin doesn't return text of matched files. If you comment out configuration of
(You can also see this behavior of not being able to report There is not much documentation on this, but you can see here that depending on the parsed language
This PR enables every rule to execute on other types of root AST nodes. |
@ic4l4s9c i see, thanks for your context, now i know the issue here. |
@ic4l4s9c thanks for your contribution! it has been released in version 3.1.0! |
ESLint officially supports linting of JSON, Markdown and CSS files.
This PR brings compatibility with currently existing parsers/plugins for these languages.