Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provide main for brotli and non-brotli builds #1378

Closed
wants to merge 1 commit into from
Closed

Conversation

withinboredom
Copy link
Collaborator

Provides a brotli and non-brotli main file for caddy.

fixes #1377

@dunglas
Copy link
Owner

dunglas commented Feb 16, 2025

I don't think it's necessary.

The main.go file is just there for convenience for "internal" (or at least "standard" builds: they allow to be sure of the exact dependencies used.

Users should use xcaddy for custom builds with custom modules or dependencies. xcaddy will generate the appropriate main.go file.

@withinboredom
Copy link
Collaborator Author

Makes sense!

@withinboredom withinboredom deleted the main-no-br branch February 16, 2025 13:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag nobrotli doesn't properly work
2 participants