Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Zeroize trait implementation for Witness #820

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Mar 14, 2024

Resolves #818

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (c79dc3b) to head (8957552).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files          57       57           
  Lines        3687     3687           
=======================================
  Hits         3146     3146           
  Misses        541      541           
Files Coverage Δ
src/composer/constraint_system/witness.rs 66.66% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79dc3b...8957552. Read the comment docs.

@moCello moCello requested review from ureeves and ZER0 March 14, 2024 15:26
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small nits to fix; I will approve once fixed.

@moCello moCello force-pushed the mocello/818_zeroize branch from ee78aa3 to 8957552 Compare March 15, 2024 12:39
@ZER0 ZER0 self-requested a review March 15, 2024 12:48
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

@moCello moCello merged commit 8f88f7e into master Mar 15, 2024
11 checks passed
@moCello moCello deleted the mocello/818_zeroize branch March 15, 2024 12:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Zeroize for Witness
2 participants